rfc(error): improve timeout error stack trace for waitFor timeouts#92
Open
tomtomau wants to merge 2 commits intoaurelia:masterfrom
Open
rfc(error): improve timeout error stack trace for waitFor timeouts#92tomtomau wants to merge 2 commits intoaurelia:masterfrom
tomtomau wants to merge 2 commits intoaurelia:masterfrom
Conversation
b337ee6 to
584c806
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edit: I originally posted a gross hacky version but I think I found a passable solution like 15 minutes after posting the pull request and have force pushed that now
Full disclosure, I have no idea if this is a horrible idea or not 🙃
We have a stack of waitFor calls in our tests and while I was stumbling trying to resolve some problematic tests, I was frustrated that the stack trace of the exception was incredibly vague:
Even when I used a debugger, it was incredibly difficult to track down which waitFor call was causing me grief. After my solution I got a stack trace that helped my track down the specific failing call:
Again, not sure if this is a terrible way to do this (I'm running this in node with js-dom, not sure about other setups?), but I hope it at least starts a conversation - maybe I'm missing something else that's simple?